Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Side by Side Diff: PRESUBMIT.py

Issue 1645573003: Exempt Cast ozone from log spam presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 1063 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 r"gl_helper_benchmark\.cc$", 1074 r"gl_helper_benchmark\.cc$",
1075 r"^courgette[\\\/]courgette_tool\.cc$", 1075 r"^courgette[\\\/]courgette_tool\.cc$",
1076 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", 1076 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$",
1077 r"^ipc[\\\/]ipc_logging\.cc$", 1077 r"^ipc[\\\/]ipc_logging\.cc$",
1078 r"^native_client_sdk[\\\/]", 1078 r"^native_client_sdk[\\\/]",
1079 r"^remoting[\\\/]base[\\\/]logging\.h$", 1079 r"^remoting[\\\/]base[\\\/]logging\.h$",
1080 r"^remoting[\\\/]host[\\\/].*", 1080 r"^remoting[\\\/]host[\\\/].*",
1081 r"^sandbox[\\\/]linux[\\\/].*", 1081 r"^sandbox[\\\/]linux[\\\/].*",
1082 r"^tools[\\\/]", 1082 r"^tools[\\\/]",
1083 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$", 1083 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",
1084 r"^ui[\\\/]ozone[\\\/]platform[\\\/]cast[\\\/]",
1084 r"^storage[\\\/]browser[\\\/]fileapi[\\\/]" + 1085 r"^storage[\\\/]browser[\\\/]fileapi[\\\/]" +
1085 r"dump_file_system.cc$",)) 1086 r"dump_file_system.cc$",))
1086 source_file_filter = lambda x: input_api.FilterSourceFile( 1087 source_file_filter = lambda x: input_api.FilterSourceFile(
1087 x, white_list=(file_inclusion_pattern,), black_list=black_list) 1088 x, white_list=(file_inclusion_pattern,), black_list=black_list)
1088 1089
1089 log_info = [] 1090 log_info = []
1090 printf = [] 1091 printf = []
1091 1092
1092 for f in input_api.AffectedSourceFiles(source_file_filter): 1093 for f in input_api.AffectedSourceFiles(source_file_filter):
1093 contents = input_api.ReadFile(f, 'rb') 1094 contents = input_api.ReadFile(f, 'rb')
(...skipping 850 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 results.extend(input_api.canned_checks.CheckTreeIsOpen( 1945 results.extend(input_api.canned_checks.CheckTreeIsOpen(
1945 input_api, 1946 input_api,
1946 output_api, 1947 output_api,
1947 json_url='http://chromium-status.appspot.com/current?format=json')) 1948 json_url='http://chromium-status.appspot.com/current?format=json'))
1948 1949
1949 results.extend(input_api.canned_checks.CheckChangeHasBugField( 1950 results.extend(input_api.canned_checks.CheckChangeHasBugField(
1950 input_api, output_api)) 1951 input_api, output_api))
1951 results.extend(input_api.canned_checks.CheckChangeHasDescription( 1952 results.extend(input_api.canned_checks.CheckChangeHasDescription(
1952 input_api, output_api)) 1953 input_api, output_api))
1953 return results 1954 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698