Issue 1645423002: Return an error in many service RPCs if the isolate is not runnable

Issue 1645423002: Return an error in many service RPCs if the isolate is not runnable (Closed)

Created:
4 years, 10 months ago by Cutch

Modified:
4 years, 10 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Return an error in many service RPCs if the isolate is not runnable - Return kIsolateMustBeRunnable error when an isolate must be runnable for a service RPC to complete. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/ce650790a1446f205a49714b717b844eed6196fd

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -41 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/json_stream.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/service.cc	View	1	40 chunks	+65 lines, -40 lines	0 comments	Download
M	runtime/vm/service/service.md	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1	6 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 7 (4 generated)

Cutch

4 years, 10 months ago (2016-01-29 19:16:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ce650790a1446f205a49714b717b844eed6196fd (presubmit successful).