Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: runtime/vm/service_test.cc

Issue 1645423002: Return an error in many service RPCs if the isolate is not runnable (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/service.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_test.cc
diff --git a/runtime/vm/service_test.cc b/runtime/vm/service_test.cc
index d55fe3ba3321c5feb9e8ea10927c62b975d0436e..dd2c004705543ed7b6606b98e6abcb140894172e 100644
--- a/runtime/vm/service_test.cc
+++ b/runtime/vm/service_test.cc
@@ -167,6 +167,7 @@ TEST_CASE(Service_Code) {
"}";
Isolate* isolate = thread->isolate();
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
Library& vmlib = Library::Handle();
@@ -273,7 +274,7 @@ TEST_CASE(Service_TokenStream) {
"}";
Isolate* isolate = thread->isolate();
-
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
Library& vmlib = Library::Handle();
@@ -332,6 +333,7 @@ TEST_CASE(Service_PcDescriptors) {
"}";
Isolate* isolate = thread->isolate();
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
Library& vmlib = Library::Handle();
@@ -393,6 +395,7 @@ TEST_CASE(Service_LocalVarDescriptors) {
"}";
Isolate* isolate = thread->isolate();
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
Library& vmlib = Library::Handle();
@@ -443,6 +446,7 @@ TEST_CASE(Service_Address) {
"}";
Isolate* isolate = thread->isolate();
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
@@ -603,6 +607,7 @@ TEST_CASE(Service_Profile) {
"}";
Isolate* isolate = thread->isolate();
+ isolate->set_is_runnable(true);
Dart_Handle lib = TestCase::LoadTestScript(kScript, NULL);
EXPECT_VALID(lib);
Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
« no previous file with comments | « runtime/vm/service/service.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698