Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1645363002: Revert of Teach navigation throttles how to cancel requests in WillProcessResponse. (Closed)

Created:
4 years, 10 months ago by Mike West
Modified:
4 years, 10 months ago
Reviewers:
clamy, davidben, mmenke, nasko
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, loading-reviews_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Teach navigation throttles how to cancel requests in WillProcessResponse. (patchset #6 id:100001 of https://codereview.chromium.org/1616943003/ ) Reason for revert: Windows tree doesn't like me: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/45328/steps/browser_tests/logs/stdio Original issue's description: > Teach navigation throttles how to cancel requests in WillProcessResponse. > > This is the first step towards moving various response-time checks up > from Blink into the browser. To support things like 'X-Frame-Options', > we'll need to do throttle checks after we can evaluate headers. This > patch starts us down that path by teaching NavigationHandleImpl, > NavigationResourceThrottle, and NavigationThrottle about response-time > checks. This patch shouldn't introduce any behavioral changes, as no > NavigationThrottle actually uses the new functionality yet. > > BUG=555418 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/409b51d438ea3f99d37025372adaf4d730553857 > Cr-Commit-Position: refs/heads/master@{#372332} TBR=clamy@chromium.org,davidben@chromium.org,mmenke@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555418 Committed: https://crrev.com/398ccc10cfc9ff839270fc7d43f862d6fed3f0aa Cr-Commit-Position: refs/heads/master@{#372350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -292 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 3 chunks +5 lines, -69 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl_unittest.cc View 30 chunks +13 lines, -170 lines 0 comments Download
M content/browser/loader/navigation_resource_throttle.cc View 4 chunks +8 lines, -24 lines 0 comments Download
M content/public/browser/navigation_throttle.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/browser/navigation_throttle.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mike West
Created Revert of Teach navigation throttles how to cancel requests in WillProcessResponse.
4 years, 10 months ago (2016-01-29 15:36:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645363002/1
4 years, 10 months ago (2016-01-29 15:36:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 15:37:33 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 15:38:34 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/398ccc10cfc9ff839270fc7d43f862d6fed3f0aa
Cr-Commit-Position: refs/heads/master@{#372350}

Powered by Google App Engine
This is Rietveld 408576698