src/compiler/bytecode-graph-builder.cc - Issue 1645293003: [interpreter] Reachability is implied by live environment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1645293003: [interpreter] Reachability is implied by live environment. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-control-flow

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 493778a823c1bb596925e4d0254b01b012738c7b..c9f10f1bfe0b16a12ead6a3d5191a66c45117d2e 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -615,9 +615,9 @@ void BytecodeGraphBuilder::VisitBytecodes() {

set_bytecode_iterator(&iterator);

while (!iterator.done()) {

int current_offset = iterator.current_offset();

- if (analysis.is_reachable(current_offset)) {

- EnterAndExitExceptionHandlers(current_offset);

- SwitchToMergeEnvironment(current_offset);

+ EnterAndExitExceptionHandlers(current_offset);

+ SwitchToMergeEnvironment(current_offset);

+ if (environment() != nullptr) {

BuildLoopHeaderEnvironment(current_offset);

switch (iterator.current_bytecode()) {

« no previous file with comments | « src/compiler/bytecode-branch-analysis.cc ('k') | test/cctest/compiler/test-run-bytecode-graph-builder.cc » ('j') | no next file with comments »