Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1645043006: Fix GL readback code to handle rowbytes correctly for non-32bit formats (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GL readback code to handle rowbytes correctly for non-32bit formats Update tests to exercise more rowbytes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645043006 Committed: https://skia.googlesource.com/skia/+/9d02b264b72be64702e43cb797b7899a8a6926ca

Patch Set 1 #

Patch Set 2 : stuff #

Patch Set 3 : exempt sw #

Patch Set 4 : uncomment rowbytes vals in rwalphatest #

Total comments: 5

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -88 lines) Patch
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 2 6 chunks +14 lines, -7 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 2 3 4 6 chunks +91 lines, -76 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 10 months ago (2016-02-01 15:15:35 UTC) #4
robertphillips
lgtm + a nit & a suggestion https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTest.cpp File tests/ReadWriteAlphaTest.cpp (right): https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTest.cpp#newcode69 tests/ReadWriteAlphaTest.cpp:69: match = ...
4 years, 10 months ago (2016-02-01 15:38:32 UTC) #5
bsalomon
https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTest.cpp File tests/ReadWriteAlphaTest.cpp (right): https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTest.cpp#newcode69 tests/ReadWriteAlphaTest.cpp:69: match = true; On 2016/02/01 15:38:31, robertphillips wrote: > ...
4 years, 10 months ago (2016-02-01 20:18:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645043006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645043006/80001
4 years, 10 months ago (2016-02-01 20:18:20 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 20:49:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9d02b264b72be64702e43cb797b7899a8a6926ca

Powered by Google App Engine
This is Rietveld 408576698