Fix GL readback code to handle rowbytes correctly for non-32bit formats

Fix GL readback code to handle rowbytes correctly for non-32bit formats

Update tests to exercise more rowbytes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645043006

Committed: https://skia.googlesource.com/skia/+/9d02b264b72be64702e43cb797b7899a8a6926ca

[bsalomon, 2016-01-30 04:45:06]

Description was changed from

==========
readback

BUG=skia:
==========

to

==========
readback

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-01 15:15:28]

Description was changed from

==========
readback

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix GL readback code to handle rowbytes correctly for non-32bit formats

Update tests to exercise more rowbytes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-01 15:15:28]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-02-01 15:38:32]

lgtm + a nit & a suggestion

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
File tests/ReadWriteAlphaTest.cpp (right):

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:69: match = true;
Can we have a subroutine for this that we also use ...

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:161: // clear readback to something non-zero so we
can detect readback failures
0x0 -> 0x1 ?

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:167: 
... here ?

[bsalomon, 2016-02-01 20:18:10]

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
File tests/ReadWriteAlphaTest.cpp (right):

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:69: match = true;
On 2016/02/01 15:38:31, robertphillips wrote:
> Can we have a subroutine for this that we also use ...

Done.

https://codereview.chromium.org/1645043006/diff/60001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:161: // clear readback to something non-zero so we
can detect readback failures
On 2016/02/01 15:38:31, robertphillips wrote:
> 0x0 -> 0x1 ?

Changed the comment, this doesn't need to be non-zero

[bsalomon, 2016-02-01 20:18:13]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-01 20:18:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1645043006/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-01 20:18:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645043006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645043006/80001

[commit-bot: I haz the power, 2016-02-01 20:49:33]

Description was changed from

==========
Fix GL readback code to handle rowbytes correctly for non-32bit formats

Update tests to exercise more rowbytes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix GL readback code to handle rowbytes correctly for non-32bit formats

Update tests to exercise more rowbytes.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9d02b264b72be64702e43cb797b7899a8a6926ca
==========

[commit-bot: I haz the power, 2016-02-01 20:49:34]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9d02b264b72be64702e43cb797b7899a8a6926ca