chrome/browser/media/webrtc_browsertest_base.h - Issue 1645043004: WebRtcBrowserTest with VP8 and VP9. WebRtcTestBase::NegotiateCall specifying video codec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_browsertest_base.h

Issue 1645043004: WebRtcBrowserTest with VP8 and VP9. WebRtcTestBase::NegotiateCall specifying video codec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (Updated comments, js include order of munge_sdp.js: after peerconnection.js) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/chrome_webrtc_browsertest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.cc » ('j') | chrome/browser/media/webrtc_browsertest_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_browsertest_base.h

diff --git a/chrome/browser/media/webrtc_browsertest_base.h b/chrome/browser/media/webrtc_browsertest_base.h

index 486e1eeefb6a558da34257671ae2226e004f662b..1bb5d10f2180087b0af9aec59b9b40015464f1ba 100644

--- a/chrome/browser/media/webrtc_browsertest_base.h

+++ b/chrome/browser/media/webrtc_browsertest_base.h

@@ -104,8 +104,12 @@ class WebRtcTestBase : public InProcessBrowserTest {

// respective tabs. Before calling this, you must have prepared peer

// connections in both tabs and configured them as you like (for instance by

// calling SetupPeerconnectionWithLocalStream).

+ // If |video_codec| is a non-empty string, the SDP offer is modified (and SDP

+ // answer verified) so that the specified video codec (case-sensitive name) is

+ // used during the call instead of the default one.

void NegotiateCall(content::WebContents* from_tab,

- content::WebContents* to_tab) const;

+ content::WebContents* to_tab,

+ const std::string& video_codec = "") const;

// Hangs up a negotiated call.

void HangUp(content::WebContents* from_tab) const;

@@ -139,9 +143,11 @@ class WebRtcTestBase : public InProcessBrowserTest {

void CloseInfoBarInTab(content::WebContents* tab_contents,

infobars::InfoBar* infobar) const;

- std::string CreateLocalOffer(content::WebContents* from_tab) const;

+ std::string CreateLocalOffer(content::WebContents* from_tab,

+ std::string default_video_codec = "") const;

std::string CreateAnswer(std::string local_offer,

- content::WebContents* to_tab) const;

+ content::WebContents* to_tab,

+ std::string default_video_codec = "") const;

void ReceiveAnswer(const std::string& answer,

content::WebContents* from_tab) const;

void GatherAndSendIceCandidates(content::WebContents* from_tab,