DescriptionWebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9 version.
After this CL, we will easily be able to test H264 as well (when that CL lands).
WebRtcTestBase::NegotiateCall and friends get a new optional parameter to specify video_codec.
The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string uses the desired codec.
All SDP helper functions in new file munge_sdp.js.
This should make it easy to add different codecs to the chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc tests in follow-up CLs.
BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/a10beae0043353c3215c3350ad877ff6689b5456
Cr-Commit-Position: refs/heads/master@{#372953}
Patch Set 1 #Patch Set 2 : VP8 and VP9 tests #Patch Set 3 : Verify that |videoCodec| is the default video codec in the SDP answer (not just the offer) #Patch Set 4 : (Updated comments, js include order of munge_sdp.js: after peerconnection.js) #
Total comments: 16
Patch Set 5 : Addressed comments #
Total comments: 4
Patch Set 6 : knitted the nits #Messages
Total messages: 21 (14 generated)
|