WebRtcBrowserTest with VP8 and VP9. WebRtcTestBase::NegotiateCall specifying video codec.

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9 version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/a10beae0043353c3215c3350ad877ff6689b5456
Cr-Commit-Position: refs/heads/master@{#372953}

[hbos_chromium, 2016-01-29 15:03:10]

Description was changed from

==========
peerconnection.js: Ability to specify codec by munging offer SDP.

Used by WebRtcTestBase::CreateLocalOffer (which is used by
WebRtcTestBase::NegotiateCall), this allows webrtc browser tests such as
chrome_webrtc_browsertest.cc, chrome_webrtc_perf_browsertest.cc and
chrome_webrtc_video_quality_browsertest.cc to choose which codec to use in their
tests.

BUG=chromium:500605, chromium:468365
==========

to

==========
Expanding webrtc browsertest coverage to test different codecs.

peerconnection.js/createLocalOffer: Ability to specify codec by munging offer
SDP (munge_sdp.js added).

Used by WebRtcTestBase::CreateLocalOffer (which is used by
WebRtcTestBase::NegotiateCall), this allows webrtc browser tests such as
chrome_webrtc_browsertest.cc, chrome_webrtc_perf_browsertest.cc and
chrome_webrtc_video_quality_browsertest.cc to choose which codec to use in their
tests.

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-01-29 15:05:49]

Description was changed from

==========
Expanding webrtc browsertest coverage to test different codecs.

peerconnection.js/createLocalOffer: Ability to specify codec by munging offer
SDP (munge_sdp.js added).

Used by WebRtcTestBase::CreateLocalOffer (which is used by
WebRtcTestBase::NegotiateCall), this allows webrtc browser tests such as
chrome_webrtc_browsertest.cc, chrome_webrtc_perf_browsertest.cc and
chrome_webrtc_video_quality_browsertest.cc to choose which codec to use in their
tests.

BUG=chromium:500605, chromium:468365
==========

to

==========
Expanding webrtc browsertest coverage to test different codecs.

peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added).

Used by WebRtcTestBase::CreateLocalOffer (which is used by
WebRtcTestBase::NegotiateCall), this allows webrtc browser tests such as
chrome_webrtc_browsertest.cc, chrome_webrtc_perf_browsertest.cc and
chrome_webrtc_video_quality_browsertest.cc to choose which video codec to use in
their tests.

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-01-29 15:05:50]

hbos@chromium.org changed reviewers:
+ phoglund@chromium.org

[hbos_chromium, 2016-01-29 15:55:54]

Description was changed from

==========
Expanding webrtc browsertest coverage to test different codecs.

peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added).

Used by WebRtcTestBase::CreateLocalOffer (which is used by
WebRtcTestBase::NegotiateCall), this allows webrtc browser tests such as
chrome_webrtc_browsertest.cc, chrome_webrtc_perf_browsertest.cc and
chrome_webrtc_video_quality_browsertest.cc to choose which video codec to use in
their tests.

BUG=chromium:500605, chromium:468365
==========

to

==========
Expanding webrtc browsertest coverage to test different codecs.

WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

(This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.)

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-01-29 15:58:22]

Description was changed from

==========
Expanding webrtc browsertest coverage to test different codecs.

WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

(This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.)

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

(This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.)

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-02-01 13:01:32]

Patchset #4 (id:60001) has been deleted

[hbos_chromium, 2016-02-01 13:13:18]

Patchset #4 (id:80001) has been deleted

[hbos_chromium, 2016-02-01 13:14:17]

Please take a look, phoglund.

[hbos_chromium, 2016-02-01 13:17:49]

Description was changed from

==========
WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

(This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.)

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-02-01 13:18:39]

Description was changed from

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::CreateLocalOffer and ::NegotiateCall get a new optional
parameter to specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-02-01 13:20:03]

Description was changed from

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string (munge_sdp.js added)

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string
uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

[phoglund_chromium, 2016-02-01 14:20:44]

Looks good in general, some minor comments

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
File chrome/browser/media/webrtc_browsertest_base.cc (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
chrome/browser/media/webrtc_browsertest_base.cc:320: if (default_video_codec !=
"")
nit:
if (default_video_codec.empty())
  default_video_codec = "null";
else
  default_video_codec = ...;

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
chrome/browser/media/webrtc_browsertest_base.cc:338: if (default_video_codec !=
"")
Nit: same here

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
File chrome/test/data/webrtc/munge_sdp.js (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:33: failure_('sdpPreferCodec', 'Unknown ID
for |codec| = \'' + codec + '\'.');
This function is undefined. use failTest defined here instead:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...

and ensure this file is included in the html after test_functions.js.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:47: * @param {!String} videoCodec If
not null, promotes the specified codec to be
Remove the !, which means that the parameter is mandatory.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:74: * @param {!string} videoCodec If
not null, verifies that the specified codec
Same here

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:74: * @param {!string} videoCodec If
not null, verifies that the specified codec
Call this expectedVideoCodec

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:98: if (videoCodec !== null) {
Break this out into a new function verifyDefaultVideoCodecIs(sdp,
expectedVideoCodec) which you call from the C++ code. I think this function is
starting to do too much, and we may as well call this from C++. You'll have to
do some JSON parsing but that's alright I think.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:101: failure_('createAnswer',
Should be failTest. Also note failTest takes one argument and not two.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:105: failure_('createAnswer',
Same here

[hbos_chromium, 2016-02-02 14:07:19]

PTAL phoglund

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
File chrome/browser/media/webrtc_browsertest_base.cc (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
chrome/browser/media/webrtc_browsertest_base.cc:320: if (default_video_codec !=
"")
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> nit:
> if (default_video_codec.empty())
>   default_video_codec = "null";
> else
>   default_video_codec = ...;

Done.

https://codereview.chromium.org/1645043004/diff/100001/chrome/browser/media/w...
chrome/browser/media/webrtc_browsertest_base.cc:338: if (default_video_codec !=
"")
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> Nit: same here

Done.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
File chrome/test/data/webrtc/munge_sdp.js (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/munge_sdp.js:33: failure_('sdpPreferCodec', 'Unknown ID
for |codec| = \'' + codec + '\'.');
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> This function is undefined. use failTest defined here instead:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...
> 
> and ensure this file is included in the html after test_functions.js.

Moved success_ and failure_ to test_functions.js and dropped the '_'.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:47: * @param {!String} videoCodec If
not null, promotes the specified codec to be
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> Remove the !, which means that the parameter is mandatory.

Oh so that's what it means... :) done.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:74: * @param {!string} videoCodec If
not null, verifies that the specified codec
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> Same here

Done.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:98: if (videoCodec !== null) {
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> Break this out into a new function verifyDefaultVideoCodecIs(sdp,
> expectedVideoCodec) which you call from the C++ code. I think this function is
> starting to do too much, and we may as well call this from C++. You'll have to
> do some JSON parsing but that's alright I think.

Done.

https://codereview.chromium.org/1645043004/diff/100001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:101: failure_('createAnswer',
On 2016/02/01 14:20:44, phoglund_chrome wrote:
> Should be failTest. Also note failTest takes one argument and not two.

failure_ is defined in this file.

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:123: returnToTest('ok-verified');
(Lol I wasted so much time debugging before I realized I had forgotten to call
returnToTest here...)

[phoglund_chromium, 2016-02-02 14:45:19]

lgtm

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
File chrome/test/data/webrtc/peerconnection.js (right):

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:102: * |failure_| occurs.
Nit: blank line before @param

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:102: * |failure_| occurs.
Nit: |failure|

https://codereview.chromium.org/1645043004/diff/120001/chrome/test/data/webrt...
chrome/test/data/webrtc/peerconnection.js:123: returnToTest('ok-verified');
On 2016/02/02 14:07:19, hbos_chromium wrote:
> (Lol I wasted so much time debugging before I realized I had forgotten to call
> returnToTest here...)

Yeah, the test just hangs in c++ land. I know, it's annoying.

[hbos_chromium, 2016-02-02 14:51:11]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2016-02-02 14:51:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/1645043004/#ps140001
(title: "knitted the nits")

[commit-bot: I haz the power, 2016-02-02 14:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645043004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645043004/140001

[commit-bot: I haz the power, 2016-02-02 16:11:56]

Description was changed from

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string
uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string
uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

[commit-bot: I haz the power, 2016-02-02 16:11:57]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-02-02 16:13:40]

Description was changed from

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string
uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365
==========

to

==========
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs now has a VP8 and a VP9
version.
After this CL, we will easily be able to test H264 as well (when that CL lands).

WebRtcTestBase::NegotiateCall and friends get a new optional parameter to
specify video_codec.

The javascript changes making this possible:
peerconnection.js/createLocalOffer: Ability to specify video codec by modifying
the offer SDP string.
peerconnection.js/receiveOfferFromPeer: Verifying that the SDP answer string
uses the desired codec.
All SDP helper functions in new file munge_sdp.js.

This should make it easy to add different codecs to the
chrome_webrtc_perf_browsertest.cc and chrome_webrtc_video_quality_browsertest.cc
tests in follow-up CLs.

BUG=chromium:500605, chromium:468365

Committed: https://crrev.com/a10beae0043353c3215c3350ad877ff6689b5456
Cr-Commit-Position: refs/heads/master@{#372953}
==========

[commit-bot: I haz the power, 2016-02-02 16:13:41]

Patchset 6 (id:??) landed as
https://crrev.com/a10beae0043353c3215c3350ad877ff6689b5456
Cr-Commit-Position: refs/heads/master@{#372953}