Merge 22637 - Disk Cache: Don't depend on the backend being enabled to...

Merge 22637 - Disk Cache: Don't depend on the backend being enabled to
be able to return the key of an open entry.

Whenever a critical corruption is detected by the disk cache,
the backend disables itself and starts failing all requests
until it's able to recreate the backing store.

Key's longer than 928 bytes are not stored inside the entry
itself, so a file object is required to access them. The backend
will reject any request for a file object after it is disabled,
so a user's request for the key of an open entry will also
fail.

Now we keep a pointer to the related file object (if needed) so
that we don't have to ask the backend for it when the user
requests the current key.

BUG=9952
TEST=unittest


Review URL: http://codereview.chromium.org/165030

TBR=rvargas@google.com


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23344

[rvargas1, 2009-08-13 20:00:40]

LGTM

On Thu, Aug 13, 2009 at 12:45 PM, <laforge@chromium.org> wrote:

> Reviewers: rvargas,
>
> Description:
> Merge 22637 - Disk Cache: Don't depend on the backend being enabled to
> be able to return the key of an open entry.
>
> Whenever a critical corruption is detected by the disk cache,
> the backend disables itself and starts failing all requests
> until it's able to recreate the backing store.
>
> Key's longer than 928 bytes are not stored inside the entry
> itself, so a file object is required to access them. The backend
> will reject any request for a file object after it is disabled,
> so a user's request for the key of an open entry will also
> fail.
>
> Now we keep a pointer to the related file object (if needed) so
> that we don't have to ask the backend for it when the user
> requests the current key.
>
> BUG=9952
> TEST=unittest
>
>
> Review URL: http://codereview.chromium.org/165030
>
> TBR=rvargas@google.com
>
>
> Please review this at http://codereview.chromium.org/164503
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
>  MM    net/disk_cache/backend_unittest.cc
>  MM    net/disk_cache/entry_impl.h
>  MM    net/disk_cache/entry_impl.cc
>  MM    net/disk_cache/entry_unittest.cc
>
>
>