Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 165030: Disk Cache: Don't depend on the backend being enabled to... (Closed)

Created:
11 years, 4 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Disk Cache: Don't depend on the backend being enabled to be able to return the key of an open entry. Whenever a critical corruption is detected by the disk cache, the backend disables itself and starts failing all requests until it's able to re-create the backing store. Key's longer than 928 bytes are not stored inside the entry itself, so a file object is required to access them. The backend will reject any request for a file object after it is disabled, so a user's request for the key of an open entry will also fail. Now we keep a pointer to the related file object (if needed) so that we don't have to ask the backend for it when the user requests the current key. BUG=9952 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -21 lines) Patch
M net/disk_cache/backend_unittest.cc View 2 chunks +66 lines, -0 lines 0 comments Download
M net/disk_cache/entry_impl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 3 chunks +24 lines, -19 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
11 years, 4 months ago (2009-08-06 02:50:18 UTC) #1
Nicolas Sylvain
11 years, 4 months ago (2009-08-06 15:05:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698