Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1645023002: Avoid multiple rewriting of object key expressions (Closed)

Created:
4 years, 10 months ago by nickie
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid multiple rewriting of object key expressions NonPatternRewrite was called more than once for the same AST in the case of (computed) key expressions present in object literals. As an example, in: var x = { [[...42]]: 17 }; the array containing the spread would be desugared first and then the resulting do-expression would again be desugared. This could be problematic if a computed key expression contains large nested array/object literals. R=rossberg@chromium.org BUG= Committed: https://crrev.com/077d70f0fe594151f7b28ea0c81aa0dfa3af8d52 Cr-Commit-Position: refs/heads/master@{#33632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/parsing/parser.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nickie
4 years, 10 months ago (2016-01-28 15:15:06 UTC) #1
rossberg
lgtm
4 years, 10 months ago (2016-01-29 19:38:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645023002/1
4 years, 10 months ago (2016-02-01 08:48:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 09:18:16 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:18:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/077d70f0fe594151f7b28ea0c81aa0dfa3af8d52
Cr-Commit-Position: refs/heads/master@{#33632}

Powered by Google App Engine
This is Rietveld 408576698