Avoid multiple rewriting of object key expressions

src/parsing/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parsing/parser.h"
 
 #include "src/api.h"
 #include "src/ast/ast.h"
 #include "src/ast/ast-expression-rewriter.h"
 #include "src/ast/ast-expression-visitor.h"
@@ skipping 5543 matching lines @@
       return true;
     }
     if (expr->IsBinaryOperation() &&
         expr->AsBinaryOperation()->op() == Token::COMMA) {
       return true;
     }
     // Everything else does not need rewriting.
     return false;
   }
 
+  void VisitObjectLiteralProperty(ObjectLiteralProperty* property) override {
+    if (property == nullptr) return;
+    // Do not rewrite (computed) key expressions
+    AST_REWRITE_PROPERTY(Expression, property, value);
+  }
+
   Parser* parser_;
 };
 
 
 Expression* Parser::RewriteNonPattern(Expression* expr,
                                       const ExpressionClassifier* classifier,
                                       bool* ok) {
   ValidateExpression(classifier, ok);
   if (!*ok) return expr;
   NonPatternRewriter rewriter(stack_limit_, this);
   Expression* result = reinterpret_cast<Expression*>(rewriter.Rewrite(expr));
   DCHECK_NOT_NULL(result);
   return result;
 }
 
 
 ObjectLiteralProperty* Parser::RewriteNonPatternObjectLiteralProperty(
     ObjectLiteralProperty* property, const ExpressionClassifier* classifier,
     bool* ok) {
   if (property != nullptr) {
-    Expression* key = RewriteNonPattern(property->key(), classifier, ok);
-    property->set_key(key);
+    // Do not rewrite (computed) key expressions
     Expression* value = RewriteNonPattern(property->value(), classifier, ok);
     property->set_value(value);
   }
   return property;
 }
 
 
 void Parser::RewriteDestructuringAssignments() {
   FunctionState* func = function_state_;
   if (!allow_harmony_destructuring_assignment()) return;
@@ skipping 196 matching lines @@
     auto class_literal = value->AsClassLiteral();
     if (class_literal->raw_name() == nullptr) {
       class_literal->set_raw_name(name);
     }
   }
 }
 
 
 }  // namespace internal
 }  // namespace v8