Issue 164493004: Docserver: Strip extension from template filenames on presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164493004: Docserver: Strip extension from template filenames on presubmit (Closed)

Created:
6 years, 10 months ago by Ken Rockot(use gerrit already)

Modified:
6 years, 10 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Docserver: Strip extension from template filenames on presubmit Because the docserver now redirects foo.html to foo, presubmit tests have been changed to query extensionless URLs for corresponding template files. BUG=343614 R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251158

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/extensions/PRESUBMIT.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm https://codereview.chromium.org/164493004/diff/1/chrome/common/extensions/PRESUBMIT.py File chrome/common/extensions/PRESUBMIT.py (right): https://codereview.chromium.org/164493004/diff/1/chrome/common/extensions/PRESUBMIT.py#newcode51 chrome/common/extensions/PRESUBMIT.py:51: matches.append(os.path.splitext(template)[0]) Comment needed

6 years, 10 months ago (2014-02-13 22:12:32 UTC) #2

Ken Rockot(use gerrit already)

6 years, 10 months ago (2014-02-13 22:33:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r251158 (presubmit successful).

Expand Messages | Collapse Messages