chrome/common/extensions/PRESUBMIT.py - Issue 164493004: Docserver: Strip extension from template filenames on presubmit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 164493004: Docserver: Strip extension from template filenames on presubmit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/PRESUBMIT.py

diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py

index 2e138c94db282c94ab52cd1ed24e765e061fd2b7..ed80458a8de3cac94bb80aadc3951ccc0cf3ecaa 100644

--- a/chrome/common/extensions/PRESUBMIT.py

+++ b/chrome/common/extensions/PRESUBMIT.py

@@ -48,7 +48,9 @@ def _FindMatchingTemplates(template_name, template_path_list):

unix_name = _UnixName(template_name)

for template in template_path_list:

if unix_name == _UnixName(template.split(os.sep)[-1]):

- matches.append(template)

+ # The docserver expects clean (extensionless) template URLs, so we strip

+ # extensions here when generating the list of matches.

+ matches.append(os.path.splitext(template)[0])

return matches

def _SanitizeAPIName(name, api_path):

« no previous file with comments | « no previous file | no next file » | no next file with comments »