Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 164483002: Fix printing unittests after revert of r230235 (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix printing unittests after revert of r230235 r251066 reverted the backgrounding of the print dialog. Before the revert http://src.chromium.org/viewvc/chrome/trunk/src/printing/printing_context_win_unittest.cc?r1=232466&r2=232611 assumed they were going to be async, so added RunLoop. Now that the dialog is synchronous again, remove that code which is causing the MessageLoop to complain. TBR=vitalybuka@chromium.org R=asvitkine@chromium.org BUG=180997, 342697 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M printing/printing_context_win_unittest.cc View 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 10 months ago (2014-02-13 19:42:29 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 10 months ago (2014-02-13 19:42:49 UTC) #2
scottmg
Committed patchset #1 manually as r251102 (tree was closed).
6 years, 10 months ago (2014-02-13 19:43:07 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-13 19:51:15 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698