Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: printing/printing_context_win_unittest.cc

Issue 164483002: Fix printing unittests after revert of r230235 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_win_unittest.cc
diff --git a/printing/printing_context_win_unittest.cc b/printing/printing_context_win_unittest.cc
index 94f8e838552e146bcd4682ebdef98541ebe1bc76..9ba666292a4efb4d8433fd745a4b8e0843cb438b 100644
--- a/printing/printing_context_win_unittest.cc
+++ b/printing/printing_context_win_unittest.cc
@@ -10,7 +10,6 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/memory/scoped_ptr.h"
-#include "base/run_loop.h"
#include "printing/backend/printing_info_win.h"
#include "printing/printing_test.h"
#include "printing/printing_context.h"
@@ -23,7 +22,6 @@ class PrintingContextTest : public PrintingTest<testing::Test> {
public:
void PrintSettingsCallback(printing::PrintingContext::Result result) {
result_ = result;
- base::MessageLoop::current()->QuitWhenIdle();
}
protected:
@@ -161,7 +159,6 @@ TEST_F(PrintingContextTest, Base) {
}
TEST_F(PrintingContextTest, PrintAll) {
- base::MessageLoopForUI loop;
if (IsTestCaseDisabled())
return;
@@ -171,9 +168,7 @@ TEST_F(PrintingContextTest, PrintAll) {
context.AskUserForSettings(
NULL, 123, false, base::Bind(&PrintingContextTest::PrintSettingsCallback,
base::Unretained(this)));
- base::RunLoop().Run();
EXPECT_EQ(printing::PrintingContext::OK, result());
-
printing::PrintSettings settings = context.settings();
EXPECT_EQ(settings.ranges().size(), 0);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698