chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 1644773003: Remove BrowserIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 9a9de9c12d4097a97e86f030ac27392efdd4f59b..f3c8874214233421d76b36079e907f068ee4218c 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -19,7 +19,6 @@

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

-#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/host_desktop.h"

@@ -1507,10 +1506,10 @@ IN_PROC_BROWSER_TEST_P(DetachToBrowserTabDragControllerTest,

// Should be two windows and not dragging.

ASSERT_FALSE(TabDragController::IsActive());

ASSERT_EQ(2u, browser_list->size());

- for (chrome::BrowserIterator it; !it.done(); it.Next()) {

- EXPECT_FALSE(GetIsDragged(*it));

+ for (auto* browser : *BrowserList::GetInstance()) {

+ EXPECT_FALSE(GetIsDragged(browser));

// Should not be maximized

- EXPECT_FALSE(it->window()->IsMaximized());

+ EXPECT_FALSE(browser->window()->IsMaximized());

}