chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 1644773003: Remove BrowserIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index 1d4faf0980bde8ab58352b07b5d74aff1589bd6d..82b4d769b7bb67b55a6d1a69bf62cd2333533657 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -1811,7 +1811,7 @@ gfx::NativeWindow TabDragController::GetLocalProcessWindow(

// window which was used for dragging is not hidden once all of its tabs are

// attached to another browser window in DragBrowserToNewTabStrip().

// TODO(pkotwicz): Fix this properly (crbug.com/358482)

- for (auto& browser : *BrowserList::GetInstance()) {

+ for (auto* browser : *BrowserList::GetInstance()) {

if (browser->tab_strip_model()->empty())

exclude.insert(browser->window()->GetNativeWindow());

}