chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc - Issue 1644773003: Remove BrowserIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/sync/browser_synced_window_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

index 5e96d5d0d661ca9e4cbf0145780a3732d987279b..29def8110a603cc0ea14777bdb7318a565d490c1 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

@@ -16,7 +16,7 @@

#include "chrome/browser/signin/signin_promo.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

-#include "chrome/browser/ui/browser_iterator.h"

+#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/startup/startup_browser_creator.h"

#include "chrome/browser/ui/startup/startup_browser_creator_impl.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -36,9 +36,9 @@ Browser* FindOneOtherBrowser(Browser* browser) {

browser->host_desktop_type()));

// Find the new browser.

- for (chrome::BrowserIterator it; !it.done(); it.Next()) {

- if (*it != browser)

- return *it;

+ for (auto* b : *BrowserList::GetInstance()) {

+ if (b != browser)

+ return b;

}

return nullptr;