Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2929)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index 758f5751163e1895b57c779c6a9b9d5cb3768aa4..2515fb535ecb30e7108d976a026076a8b89f4f90 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -30,7 +30,6 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "chrome/browser/ui/browser_window.h"
@@ -92,9 +91,9 @@ Browser* FindOneOtherBrowser(Browser* browser) {
// Find the new browser.
Browser* other_browser = NULL;
- for (chrome::BrowserIterator it; !it.done() && !other_browser; it.Next()) {
- if (*it != browser)
- other_browser = *it;
+ for (auto* b : *BrowserList::GetInstance()) {
+ if (b != browser)
+ other_browser = b;
}
return other_browser;
}
@@ -190,9 +189,9 @@ class StartupBrowserCreatorTest : public ExtensionBrowserTest {
Browser* FindOneOtherBrowserForProfile(Profile* profile,
Browser* not_this_browser) {
- for (chrome::BrowserIterator it; !it.done(); it.Next()) {
- if (*it != not_this_browser && it->profile() == profile)
- return *it;
+ for (auto* browser : *BrowserList::GetInstance()) {
+ if (browser != not_this_browser && browser->profile() == profile)
+ return browser;
}
return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698