Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1644683002: A missing enum case in a switch is a warning, not a compile-time error. (Closed)

Created:
4 years, 11 months ago by Bob Nystrom
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

A missing enum case in a switch is a warning, not a compile-time error. Fixes #25576. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4af641864f9fb2c00cd5bc0be2c6ad7e2a110d5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 5 chunks +19 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 11 months ago (2016-01-27 19:12:34 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-01-28 18:32:19 UTC) #3
Bob Nystrom
4 years, 10 months ago (2016-01-28 19:11:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4af641864f9fb2c00cd5bc0be2c6ad7e2a110d5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698