Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Side by Side Diff: pkg/analyzer/test/generated/static_warning_code_test.dart

Issue 1644683002: A missing enum case in a switch is a warning, not a compile-time error. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/test/generated/compile_time_error_code_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.test.generated.static_warning_code_test; 5 library analyzer.test.generated.static_warning_code_test;
6 6
7 import 'package:analyzer/src/generated/error.dart'; 7 import 'package:analyzer/src/generated/error.dart';
8 import 'package:analyzer/src/generated/source_io.dart'; 8 import 'package:analyzer/src/generated/source_io.dart';
9 import 'package:unittest/unittest.dart'; 9 import 'package:unittest/unittest.dart';
10 10
(...skipping 3598 matching lines...) Expand 10 before | Expand all | Expand 10 after
3609 } 3609 }
3610 3610
3611 void test_voidReturnForGetter() { 3611 void test_voidReturnForGetter() {
3612 Source source = addSource(r''' 3612 Source source = addSource(r'''
3613 class S { 3613 class S {
3614 void get value {} 3614 void get value {}
3615 }'''); 3615 }''');
3616 computeLibrarySourceErrors(source); 3616 computeLibrarySourceErrors(source);
3617 assertErrors(source, [StaticWarningCode.VOID_RETURN_FOR_GETTER]); 3617 assertErrors(source, [StaticWarningCode.VOID_RETURN_FOR_GETTER]);
3618 } 3618 }
3619
3620 void test_missingEnumConstantInSwitch() {
3621 Source source = addSource(r'''
3622 enum E { ONE, TWO, THREE, FOUR }
3623 bool odd(E e) {
3624 switch (e) {
3625 case E.ONE:
3626 case E.THREE: return true;
3627 }
3628 return false;
3629 }''');
3630 computeLibrarySourceErrors(source);
3631 assertErrors(source, [
3632 StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH,
3633 StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH
3634 ]);
3635 verify([source]);
3636 }
3619 } 3637 }
OLDNEW
« no previous file with comments | « pkg/analyzer/test/generated/compile_time_error_code_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698