Notification actions may have an icon url.

content/child/notifications/notification_data_conversions.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/notifications/notification_data_conversions.h"
 
 #include <stddef.h>
 
 #include "base/strings/utf_string_conversions.h"
 #include "third_party/WebKit/public/platform/URLConversion.h"
@@ skipping 32 matching lines @@
   platform_data.vibration_pattern.assign(web_data.vibrate.begin(),
                                          web_data.vibrate.end());
   platform_data.silent = web_data.silent;
   platform_data.require_interaction = web_data.requireInteraction;
   platform_data.data.assign(web_data.data.begin(), web_data.data.end());
   platform_data.actions.resize(web_data.actions.size());
   for (size_t i = 0; i < web_data.actions.size(); ++i) {
     platform_data.actions[i].action =
         base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
     platform_data.actions[i].title = web_data.actions[i].title;
+    platform_data.actions[i].icon =
+        blink::WebStringToGURL(web_data.actions[i].icon.string());

[Peter Beverloo, 2016/01/27 17:14:23]

PTAL at content/child/notifications/notification_data_conversions_unittest.cc

[jochen (gone - plz use gerrit), 2016/01/28 12:12:24]

should there be a max length of the URL?

[Michael van Ouwerkerk, 2016/02/01 14:39:22]

Are you asking because this might be too large for Chrome to handle? Shouldn't
that kind of check take place in the JS bindings already, or as soon after that
as possible? In this case, this enters the system as a string from JS, is passed
into ExecutionContext.completeUrl, and then into a KURL constructor.

[Michael van Ouwerkerk, 2016/02/01 14:39:23]

Done.

   }
 
   return platform_data;
 }
 
 WebNotificationData ToWebNotificationData(
     const PlatformNotificationData& platform_data) {
   WebNotificationData web_data;
   web_data.title = platform_data.title;
 
@@ skipping 17 matching lines @@
   web_data.silent = platform_data.silent;
   web_data.requireInteraction = platform_data.require_interaction;
   web_data.data = platform_data.data;
   blink::WebVector<blink::WebNotificationAction> resized(
       platform_data.actions.size());
   web_data.actions.swap(resized);
   for (size_t i = 0; i < platform_data.actions.size(); ++i) {
     web_data.actions[i].action =
         blink::WebString::fromUTF8(platform_data.actions[i].action);
     web_data.actions[i].title = platform_data.actions[i].title;
+    web_data.actions[i].icon = blink::WebURL(platform_data.actions[i].icon);
   }
 
   return web_data;
 }
 
 }  // namespace content