Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1644573002: Notification actions may have an icon url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
index 8f58d30cb08c6c5f4e6d0db2e51cd15c91c50ac8..090dd039a325ad3e98f392f672e8725bc8cb69fd 100644
--- a/content/child/notifications/notification_data_conversions_unittest.cc
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -28,8 +28,10 @@ const double kNotificationTimestamp = 621046800.;
const unsigned char kNotificationData[] = {0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf};
const char kAction1Name[] = "btn1";
const char kAction1Title[] = "Button 1";
+const char kAction1IconUrl[] = "https://example.com/action_icon_1.png";
const char kAction2Name[] = "btn2";
const char kAction2Title[] = "Button 2";
+const char kAction2IconUrl[] = "https://example.com/action_icon_2.png";
TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
blink::WebNotificationData web_data;
@@ -51,8 +53,10 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
blink::WebVector<blink::WebNotificationAction>(static_cast<size_t>(2));
web_data.actions[0].action = blink::WebString::fromUTF8(kAction1Name);
web_data.actions[0].title = blink::WebString::fromUTF8(kAction1Title);
+ web_data.actions[0].icon = blink::WebURL(GURL(kAction1IconUrl));
web_data.actions[1].action = blink::WebString::fromUTF8(kAction2Name);
web_data.actions[1].title = blink::WebString::fromUTF8(kAction2Title);
+ web_data.actions[1].icon = blink::WebURL(GURL(kAction2IconUrl));
PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title);
@@ -75,8 +79,10 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
ASSERT_EQ(web_data.actions.size(), platform_data.actions.size());
EXPECT_EQ(kAction1Name, platform_data.actions[0].action);
EXPECT_EQ(base::ASCIIToUTF16(kAction1Title), platform_data.actions[0].title);
+ EXPECT_EQ(kAction1IconUrl, platform_data.actions[0].icon.spec());
EXPECT_EQ(kAction2Name, platform_data.actions[1].action);
EXPECT_EQ(base::ASCIIToUTF16(kAction2Title), platform_data.actions[1].title);
+ EXPECT_EQ(kAction2IconUrl, platform_data.actions[1].icon.spec());
}
TEST(NotificationDataConversionsTest, ToWebNotificationData) {
@@ -102,8 +108,10 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
platform_data.actions.resize(2);
platform_data.actions[0].action = kAction1Name;
platform_data.actions[0].title = base::ASCIIToUTF16(kAction1Title);
+ platform_data.actions[0].icon = GURL(kAction1IconUrl);
platform_data.actions[1].action = kAction2Name;
platform_data.actions[1].title = base::ASCIIToUTF16(kAction2Title);
+ platform_data.actions[1].icon = GURL(kAction2IconUrl);
blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
EXPECT_EQ(kNotificationTitle, web_data.title);
@@ -129,8 +137,10 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
ASSERT_EQ(platform_data.actions.size(), web_data.actions.size());
EXPECT_EQ(kAction1Name, web_data.actions[0].action);
EXPECT_EQ(kAction1Title, web_data.actions[0].title);
+ EXPECT_EQ(kAction1IconUrl, web_data.actions[0].icon.string());
EXPECT_EQ(kAction2Name, web_data.actions[1].action);
EXPECT_EQ(kAction2Title, web_data.actions[1].title);
+ EXPECT_EQ(kAction2IconUrl, web_data.actions[1].icon.string());
}
TEST(NotificationDataConversionsTest, NotificationDataDirectionality) {
« no previous file with comments | « content/child/notifications/notification_data_conversions.cc ('k') | content/common/platform_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698