Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1644573002: Notification actions may have an icon url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions.cc
diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc
index 0c4d93911c82fa34727c1ee1fe0b1cbac8fb6ea0..be7ad40cec7164b4ff3d9ba58611f8319373b04a 100644
--- a/content/child/notifications/notification_data_conversions.cc
+++ b/content/child/notifications/notification_data_conversions.cc
@@ -52,6 +52,8 @@ PlatformNotificationData ToPlatformNotificationData(
platform_data.actions[i].action =
base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
platform_data.actions[i].title = web_data.actions[i].title;
+ platform_data.actions[i].icon =
+ blink::WebStringToGURL(web_data.actions[i].icon.string());
}
return platform_data;
@@ -90,6 +92,7 @@ WebNotificationData ToWebNotificationData(
web_data.actions[i].action =
blink::WebString::fromUTF8(platform_data.actions[i].action);
web_data.actions[i].title = platform_data.actions[i].title;
+ web_data.actions[i].icon = blink::WebURL(platform_data.actions[i].icon);
}
return web_data;

Powered by Google App Engine
This is Rietveld 408576698