Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1644393003: Use InterlockedExchangeAdd varient instead of InterlockedAdd which doesn't seem to be available on … (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use InterlockedExchangeAdd varient instead of InterlockedAdd which doesn't seem to be available on some windows platforms. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/eece23fe67a9995b65d9def47cdbb8575a6819e8

Patch Set 1 #

Patch Set 2 : fix-usage #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/vm/atomic_win.h View 1 2 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 10 months ago (2016-01-30 00:59:40 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1644393003/diff/20001/runtime/vm/atomic_win.h File runtime/vm/atomic_win.h (right): https://codereview.chromium.org/1644393003/diff/20001/runtime/vm/atomic_win.h#newcode31 runtime/vm/atomic_win.h:31: inline uintptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p, Since this changes the ...
4 years, 10 months ago (2016-01-30 01:04:21 UTC) #3
siva
https://codereview.chromium.org/1644393003/diff/20001/runtime/vm/atomic_win.h File runtime/vm/atomic_win.h (right): https://codereview.chromium.org/1644393003/diff/20001/runtime/vm/atomic_win.h#newcode31 runtime/vm/atomic_win.h:31: inline uintptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p, On 2016/01/30 01:04:20, rmacnak wrote: ...
4 years, 10 months ago (2016-01-30 01:07:26 UTC) #4
siva
4 years, 10 months ago (2016-01-30 01:09:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eece23fe67a9995b65d9def47cdbb8575a6819e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698