Use InterlockedExchangeAdd varient instead of InterlockedAdd which doesn't seem to be available on …

runtime/vm/atomic_win.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ATOMIC_WIN_H_
 #define VM_ATOMIC_WIN_H_
 
 #if !defined VM_ATOMIC_H_
 #error Do not include atomic_win.h directly. Use atomic.h instead.
 #endif
@@ skipping 10 matching lines @@
       InterlockedIncrement64(reinterpret_cast<LONGLONG*>(p))) - 1;
 #elif defined(HOST_ARCH_IA32)
   return static_cast<uintptr_t>(
       InterlockedIncrement(reinterpret_cast<LONG*>(p))) - 1;
 #else
 #error Unsupported host architecture.
 #endif
 }
 
 
 inline uintptr_t AtomicOperations::FetchAndIncrementBy(intptr_t* p,

[rmacnak, 2016/01/30 01:04:20]

Since this changes the (as yet unused) return value, consider making these void.

[siva, 2016/01/30 01:07:26]

Will fix in a new CL.

                                                        intptr_t value) {
 #if defined(HOST_ARCH_X64)
   return static_cast<uintptr_t>(
-      InterlockedAdd64(reinterpret_cast<LONGLONG*>(p),
-                       static_cast<LONGLONG>(value))) - value;
+      InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
+                               static_cast<LONGLONG>(value)));
 #elif defined(HOST_ARCH_IA32)
   return static_cast<uintptr_t>(
-      InterlockedAdd(reinterpret_cast<LONG*>(p),
-                     static_cast<LONG>(value))) - value;
+      InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
+                             static_cast<LONG>(value)));
 #else
 #error Unsupported host architecture.
 #endif
 }
 
 
 inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
 #if defined(HOST_ARCH_X64)
   return static_cast<uintptr_t>(
       InterlockedDecrement64(reinterpret_cast<LONGLONG*>(p))) + 1;
 #elif defined(HOST_ARCH_IA32)
   return static_cast<uintptr_t>(
       InterlockedDecrement(reinterpret_cast<LONG*>(p))) + 1;
 #else
 #error Unsupported host architecture.
 #endif
 }
 
 
 inline uintptr_t AtomicOperations::FetchAndDecrementBy(intptr_t* p,
                                                        intptr_t value) {
 #if defined(HOST_ARCH_X64)
   return static_cast<uintptr_t>(
-      InterlockedAdd64(reinterpret_cast<LONGLONG*>(p),
-                       static_cast<LONGLONG>(-value))) + value;
+      InterlockedExchangeAdd64(reinterpret_cast<LONGLONG*>(p),
+                               static_cast<LONGLONG>(-value)));
 #elif defined(HOST_ARCH_IA32)
   return static_cast<uintptr_t>(
-      InterlockedAdd(reinterpret_cast<LONG*>(p),
-                     static_cast<LONG>(-value))) + value;
+      InterlockedExchangeAdd(reinterpret_cast<LONG*>(p),
+                             static_cast<LONG>(-value)));
 #else
 #error Unsupported host architecture.
 #endif
 }
 
 
 #if !defined(USING_SIMULATOR)
 inline uword AtomicOperations::CompareAndSwapWord(uword* ptr,
                                                   uword old_value,
                                                   uword new_value) {
@@ skipping 21 matching lines @@
                                  static_cast<LONG>(old_value)));
 #else
 #error Unsupported host architecture.
 #endif
 }
 #endif  // !defined(USING_SIMULATOR)
 
 }  // namespace dart
 
 #endif  // VM_ATOMIC_WIN_H_