Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1644293003: Error reporting for SVGInteger and SVGIntegerOptionalInteger (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Error reporting for SVGInteger and SVGIntegerOptionalInteger Also includes a minor cleanup of SVGInteger::setValueAsString. BUG=231612 Committed: https://crrev.com/4c28209930dc99c42cf07016f0c29dbc1181b85a Cr-Commit-Position: refs/heads/master@{#372401}

Patch Set 1 #

Patch Set 2 : TestExpectations; Drop redundant test. #

Messages

Total messages: 10 (4 generated)
fs
4 years, 10 months ago (2016-01-29 18:42:17 UTC) #3
f(malita)
lgtm
4 years, 10 months ago (2016-01-29 19:54:39 UTC) #4
pdr.
lgtm
4 years, 10 months ago (2016-01-29 19:57:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644293003/20001
4 years, 10 months ago (2016-01-29 19:58:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 20:08:00 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 20:09:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c28209930dc99c42cf07016f0c29dbc1181b85a
Cr-Commit-Position: refs/heads/master@{#372401}

Powered by Google App Engine
This is Rietveld 408576698