Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGParsingError.cpp

Issue 1644293003: Error reporting for SVGInteger and SVGIntegerOptionalInteger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TestExpectations; Drop redundant test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGParsingError.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/svg/SVGParsingError.h" 5 #include "core/svg/SVGParsingError.h"
6 6
7 #include "core/dom/QualifiedName.h" 7 #include "core/dom/QualifiedName.h"
8 #include "platform/JSONValues.h" 8 #include "platform/JSONValues.h"
9 #include "wtf/text/CharacterNames.h" 9 #include "wtf/text/CharacterNames.h"
10 #include "wtf/text/StringBuilder.h" 10 #include "wtf/text/StringBuilder.h"
(...skipping 16 matching lines...) Expand all
27 { 27 {
28 switch (status) { 28 switch (status) {
29 case SVGParseStatus::TrailingGarbage: 29 case SVGParseStatus::TrailingGarbage:
30 return std::make_pair("Trailing garbage, ", "."); 30 return std::make_pair("Trailing garbage, ", ".");
31 case SVGParseStatus::ExpectedArcFlag: 31 case SVGParseStatus::ExpectedArcFlag:
32 return std::make_pair("Expected arc flag ('0' or '1'), ", "."); 32 return std::make_pair("Expected arc flag ('0' or '1'), ", ".");
33 case SVGParseStatus::ExpectedBoolean: 33 case SVGParseStatus::ExpectedBoolean:
34 return std::make_pair("Expected 'true' or 'false', ", "."); 34 return std::make_pair("Expected 'true' or 'false', ", ".");
35 case SVGParseStatus::ExpectedEnumeration: 35 case SVGParseStatus::ExpectedEnumeration:
36 return std::make_pair("Unrecognized enumerated value, ", "."); 36 return std::make_pair("Unrecognized enumerated value, ", ".");
37 case SVGParseStatus::ExpectedInteger:
38 return std::make_pair("Expected integer, ", ".");
37 case SVGParseStatus::ExpectedLength: 39 case SVGParseStatus::ExpectedLength:
38 return std::make_pair("Expected length, ", "."); 40 return std::make_pair("Expected length, ", ".");
39 case SVGParseStatus::ExpectedMoveToCommand: 41 case SVGParseStatus::ExpectedMoveToCommand:
40 return std::make_pair("Expected moveto path command ('M' or 'm'), ", "." ); 42 return std::make_pair("Expected moveto path command ('M' or 'm'), ", "." );
41 case SVGParseStatus::ExpectedNumber: 43 case SVGParseStatus::ExpectedNumber:
42 return std::make_pair("Expected number, ", "."); 44 return std::make_pair("Expected number, ", ".");
43 case SVGParseStatus::ExpectedPathCommand: 45 case SVGParseStatus::ExpectedPathCommand:
44 return std::make_pair("Expected path command, ", "."); 46 return std::make_pair("Expected path command, ", ".");
45 case SVGParseStatus::NegativeValue: 47 case SVGParseStatus::NegativeValue:
46 return std::make_pair("A negative value is not valid. (", ")"); 48 return std::make_pair("A negative value is not valid. (", ")");
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 111
110 auto message = messageForStatus(status()); 112 auto message = messageForStatus(status());
111 builder.append(message.first); 113 builder.append(message.first);
112 appendValue(builder, *this, value); 114 appendValue(builder, *this, value);
113 builder.append(message.second); 115 builder.append(message.second);
114 } 116 }
115 return builder.toString(); 117 return builder.toString();
116 } 118 }
117 119
118 } // namespace blink 120 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGParsingError.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698