Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1644233002: rewrite_to_chrome_style: Fix test expectations to match current reality (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Fix test expectations to match current reality Don't make the test fail all the time, I hates it. R=dcheng BUG=578344 Committed: https://crrev.com/b95a35a79a15df931f07d5e884e077e079b26b5c Cr-Commit-Position: refs/heads/master@{#372254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/constants-original.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
4 years, 10 months ago (2016-01-29 01:46:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644233002/1
4 years, 10 months ago (2016-01-29 01:47:25 UTC) #3
dcheng
lgtm
4 years, 10 months ago (2016-01-29 01:49:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644233002/1
4 years, 10 months ago (2016-01-29 01:56:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 02:18:57 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 02:20:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b95a35a79a15df931f07d5e884e077e079b26b5c
Cr-Commit-Position: refs/heads/master@{#372254}

Powered by Google App Engine
This is Rietveld 408576698