Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

Issue 1644233002: rewrite_to_chrome_style: Fix test expectations to match current reality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/tests/constants-original.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
index 1136d2ff24783bab9405c0b052e39dfa165fd209..e27982ac50f98bc3f369f7aefb083675edcff91e 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
@@ -33,8 +33,10 @@ class C {
const int kFunctionConstantFromExpression = 4 + 6;
const int kFunctionConstantFromOtherConsts =
kFunctionConstant + kFunctionConstantFromExpression;
- const int kShouldBeRenamedToAConst = 9 - 2;
- const int kShouldAlsoBeRenamedToAConst =
+ // These don't do the right thing right now, but names like this don't
+ // exist in blink (hopefully).
+ const int kShould_be_renamed_to_a_const = 9 - 2;
+ const int kShould_also_be_renamed_to_a_const =
kFunctionConstant + kFunctionConstantFromOtherConsts;
const int not_compile_time_const = kFunctionConstant + Function();
}
« no previous file with comments | « no previous file | tools/clang/rewrite_to_chrome_style/tests/constants-original.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698