Issue 164415: Mac: autocomplete popup size and shape mirrors star/go buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164415: Mac: autocomplete popup size and shape mirrors star/go buttons. (Closed)

Created:
11 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: autocomplete popup size and shape mirrors star/go buttons. Also line up image and title columns under star and field. http://crbug.com/19182

Patch Set 2 : Added comments to drawing methods. #

Total comments: 4

Patch Set 3 : Expand a confusing comment. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -3 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	1 2	5 chunks	+86 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM http://codereview.chromium.org/164415/diff/4/5 File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right): http://codereview.chromium.org/164415/diff/4/5#newcode298 Line 298: // the toolbar controller? +1 to these ...

11 years, 4 months ago (2009-08-12 20:36:08 UTC) #2

Scott Hess - ex-Googler

11 years, 4 months ago (2009-08-12 21:04:45 UTC) #3

Thanks.

http://codereview.chromium.org/164415/diff/4/5
File chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (right):

http://codereview.chromium.org/164415/diff/4/5#newcode298
Line 298: // the toolbar controller?
On 2009/08/12 20:36:08, rohitrao wrote:
> +1 to these bounds coming from the toolbar controller.  The current logic is
> probably stable, but feels oh so fragile.  I'll look into making that happen.

Honestly, plumbing out to the toolbar controller feels pretty brittle.  :-). 
Another option would be to make the star/field/go button a formal unit of some
sort (location bar is kinda this, but not completely).

http://codereview.chromium.org/164415/diff/4/5#newcode390
Line 390: // center of the image instead of the left-hand side?
On 2009/08/12 20:36:08, rohitrao wrote:
> I don't understand this TODO.  Are we left-justifying images, and the TODO is
> questioning whether we should center them instead?

Updated the comment with more info.