Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: components/test_runner/test_runner.cc

Issue 1644063002: Simplify TestRunnerBindings::SimulateWebNotificationClick param handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 8d41bbd0b09309e6c2b9519255eb812b37f10437..08bb12a5162e922d95369a7ac6d361a9df30052e 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -295,7 +295,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
v8::Local<v8::Function> callback);
void SetPOSIXLocale(const std::string& locale);
void SetMIDIAccessorResult(bool result);
- void SimulateWebNotificationClick(gin::Arguments* args);
+ void SimulateWebNotificationClick(const std::string& title, int action_index);
void AddMockSpeechRecognitionResult(const std::string& transcript,
double confidence);
void SetMockSpeechRecognitionError(const std::string& error,
@@ -1413,16 +1413,11 @@ void TestRunnerBindings::SetMIDIAccessorResult(bool result) {
runner_->SetMIDIAccessorResult(result);
}
-void TestRunnerBindings::SimulateWebNotificationClick(gin::Arguments* args) {
+void TestRunnerBindings::SimulateWebNotificationClick(const std::string& title,
+ int action_index) {
if (!runner_)
return;
- std::string title;
- int action_index = -1;
- if (args->GetNext(&title) &&
- (args->PeekNext().IsEmpty() || args->GetNext(&action_index)))
- runner_->SimulateWebNotificationClick(title, action_index);
- else
- args->ThrowError();
+ runner_->SimulateWebNotificationClick(title, action_index);
}
void TestRunnerBindings::AddMockSpeechRecognitionResult(
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698