third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html - Issue 1644063002: Simplify TestRunnerBindings::SimulateWebNotificationClick param handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html

Issue 1644063002: Simplify TestRunnerBindings::SimulateWebNotificationClick param handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/test_runner.cc ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/resources/click-event-test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html b/third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html

index e7d2a649d6db62c60ce95c56ed2a9a387d765f5e..c2dd86e81b19dec510f3bda7b62f06d0a0eb75b7 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html

@@ -33,7 +33,7 @@

var notification = new Notification('My Notification');

notification.addEventListener('show', test.step_func(function() {

if (window.testRunner)

- testRunner.simulateWebNotificationClick('My Notification');

+ testRunner.simulateWebNotificationClick('My Notification', -1 /* action_index */);

}));

notification.addEventListener('click', test.step_func(function() {