Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1644063002: Simplify TestRunnerBindings::SimulateWebNotificationClick param handling (Closed)

Created:
4 years, 10 months ago by Nina
Modified:
4 years, 10 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, tzik, Peter Beverloo, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify TestRunnerBindings::SimulateWebNotificationClick param handling This CL reduces complexity on the TestRunnerBindings::SimulateWebNotificationClick method by having it receive the actual parameters instead of unpacking them from a gin::Arguments object. BUG=582124 TEST=LayoutTests/http/tests/notifications/* Committed: https://crrev.com/c0939ba76ea40b78a7599cfa7915dac7df8c669b Cr-Commit-Position: refs/heads/master@{#373304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M components/test_runner/test_runner.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/click-window-focus-document.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/resources/click-event-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/resources/worker-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-event.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-action-reflection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-click.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-close.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-direction.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-click.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-focus.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/notificationclick-can-openwindow.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/windowclient-focus.html View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (9 generated)
Nina
Hi John, Would you minding giving this patch a look? Thanks. Nico.
4 years, 10 months ago (2016-01-28 17:17:14 UTC) #3
Nina
CC Peter - sorry for the spam :)
4 years, 10 months ago (2016-01-28 17:17:42 UTC) #5
johnme
lgtm, thanks :)
4 years, 10 months ago (2016-01-28 19:12:12 UTC) #6
Nina
Hi Rick, Could you give test_runner.cc a review? Thanks, Nico.
4 years, 10 months ago (2016-02-01 11:36:06 UTC) #9
Rick Byers
test_runner LGTM - thanks for the cleanup!
4 years, 10 months ago (2016-02-02 04:46:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644063002/1
4 years, 10 months ago (2016-02-03 10:46:27 UTC) #12
commit-bot: I haz the power
The author nsatragno@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 10 months ago (2016-02-03 10:46:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644063002/1
4 years, 10 months ago (2016-02-03 18:00:32 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 19:37:29 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 19:38:34 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0939ba76ea40b78a7599cfa7915dac7df8c669b
Cr-Commit-Position: refs/heads/master@{#373304}

Powered by Google App Engine
This is Rietveld 408576698