Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1643843002: Add a document-by-document JSON transformer. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a document-by-document JSON transformer. This makes it easy to send JSON over WebSocket connections, for example. R=rnystrom@google.com Committed: https://github.com/dart-lang/stream_channel/commit/5d86c82544cd96ded2b13bf32e29513113276e2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A lib/src/json_document_transformer.dart View 1 chunk +41 lines, -0 lines 0 comments Download
M lib/stream_channel.dart View 1 chunk +1 line, -0 lines 0 comments Download
A test/json_document_transformer_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2016-01-28 01:15:13 UTC) #1
Bob Nystrom
lgtm
4 years, 10 months ago (2016-01-28 19:16:03 UTC) #2
nweiz
4 years, 10 months ago (2016-01-28 20:00:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d86c82544cd96ded2b13bf32e29513113276e2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698