Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1643753003: X87: [turbofan] Fixing IMulHigh, which has a temp. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Fixing IMulHigh, which has a temp. port a685180d38fe6c8b8878e8b0638e475221be37fe (r33535) original commit message: On Intel, imul clobbers {r|e}ax. We're missing that in the representation of the MulHigh intermediate instructions. Fixing, by adding it as a temp, akin VisitDiv does. BUG= Committed: https://crrev.com/1aac4c383c903660e3bf03d7d05852f8e672c32f Cr-Commit-Position: refs/heads/master@{#33567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-28 03:13:40 UTC) #2
Mircea Trofin
lgtm
4 years, 11 months ago (2016-01-28 03:21:17 UTC) #3
Weiliang
lgtm
4 years, 11 months ago (2016-01-28 03:59:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643753003/1
4 years, 11 months ago (2016-01-28 04:01:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 04:18:27 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 04:19:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aac4c383c903660e3bf03d7d05852f8e672c32f
Cr-Commit-Position: refs/heads/master@{#33567}

Powered by Google App Engine
This is Rietveld 408576698