Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1643753003: X87: [turbofan] Fixing IMulHigh, which has a temp. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 g.UseFixed(right, ecx)); 462 g.UseFixed(right, ecx));
463 } 463 }
464 } 464 }
465 465
466 466
467 namespace { 467 namespace {
468 468
469 void VisitMulHigh(InstructionSelector* selector, Node* node, 469 void VisitMulHigh(InstructionSelector* selector, Node* node,
470 ArchOpcode opcode) { 470 ArchOpcode opcode) {
471 X87OperandGenerator g(selector); 471 X87OperandGenerator g(selector);
472 selector->Emit(opcode, g.DefineAsFixed(node, edx), 472 InstructionOperand temps[] = {g.TempRegister(eax)};
473 g.UseFixed(node->InputAt(0), eax), 473 selector->Emit(
474 g.UseUniqueRegister(node->InputAt(1))); 474 opcode, g.DefineAsFixed(node, edx), g.UseFixed(node->InputAt(0), eax),
475 g.UseUniqueRegister(node->InputAt(1)), arraysize(temps), temps);
475 } 476 }
476 477
477 478
478 void VisitDiv(InstructionSelector* selector, Node* node, ArchOpcode opcode) { 479 void VisitDiv(InstructionSelector* selector, Node* node, ArchOpcode opcode) {
479 X87OperandGenerator g(selector); 480 X87OperandGenerator g(selector);
480 InstructionOperand temps[] = {g.TempRegister(edx)}; 481 InstructionOperand temps[] = {g.TempRegister(edx)};
481 selector->Emit(opcode, g.DefineAsFixed(node, eax), 482 selector->Emit(opcode, g.DefineAsFixed(node, eax),
482 g.UseFixed(node->InputAt(0), eax), 483 g.UseFixed(node->InputAt(0), eax),
483 g.UseUnique(node->InputAt(1)), arraysize(temps), temps); 484 g.UseUnique(node->InputAt(1)), arraysize(temps), temps);
484 } 485 }
(...skipping 864 matching lines...) Expand 10 before | Expand all | Expand 10 after
1349 MachineOperatorBuilder::kFloat32RoundTruncate | 1350 MachineOperatorBuilder::kFloat32RoundTruncate |
1350 MachineOperatorBuilder::kFloat64RoundTruncate | 1351 MachineOperatorBuilder::kFloat64RoundTruncate |
1351 MachineOperatorBuilder::kFloat32RoundTiesEven | 1352 MachineOperatorBuilder::kFloat32RoundTiesEven |
1352 MachineOperatorBuilder::kFloat64RoundTiesEven; 1353 MachineOperatorBuilder::kFloat64RoundTiesEven;
1353 return flags; 1354 return flags;
1354 } 1355 }
1355 1356
1356 } // namespace compiler 1357 } // namespace compiler
1357 } // namespace internal 1358 } // namespace internal
1358 } // namespace v8 1359 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698