Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1643653002: cc: make partially-resident textures use 1 - y, not h - y. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: make partially-resident textures use 1 - y, not h - y. In Skia, partially-resident textures of "flipped" textures occupy texcoords 1 to 1 - h (in Y). In cc, they occupy h to 0. In order to ease interop, we should pick a convention and unify. I chose the Skia model, since coords can flipped with a simple 1 - y, which doesn't require knowing the height of the active region. I also added a new test case for masks, since the math is a little hinky. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/fbfb39d126f7a6e24f369c950954298949d718a3 Cr-Commit-Position: refs/heads/master@{#371930}

Patch Set 1 #

Patch Set 2 : More plausible mask fix; new test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -10 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 4 chunks +4 lines, -9 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
A cc/test/data/mask_middle.png View 1 Binary file 0 comments Download

Messages

Total messages: 15 (9 generated)
Stephen White
enne@: PTAL. Thanks!
4 years, 10 months ago (2016-01-27 22:38:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643653002/20001
4 years, 10 months ago (2016-01-27 22:40:03 UTC) #7
enne (OOO)
lgtm, thanks!
4 years, 10 months ago (2016-01-27 23:04:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643653002/20001
4 years, 10 months ago (2016-01-27 23:10:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 00:24:22 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 00:26:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbfb39d126f7a6e24f369c950954298949d718a3
Cr-Commit-Position: refs/heads/master@{#371930}

Powered by Google App Engine
This is Rietveld 408576698