chrome/browser/safe_browsing/safe_browsing_service.h - Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1643573002: Add a ModuleLoadAnalyzer which checks modules against a whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix incorrect and misleading unit tests in for blacklist_load and suspicious_module incidents Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h

index ec8d59c98b0846bdbb1a06fe4aa4af1a564bd4e3..52371be4c23c4c217613c7d8c470a16d532ac3da 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.h

+++ b/chrome/browser/safe_browsing/safe_browsing_service.h

@@ -148,6 +148,8 @@ class SafeBrowsingService

// |callback| will be dropped if the service is not applicable for the

// process.

void RegisterDelayedAnalysisCallback(const DelayedAnalysisCallback& callback);

+ void RegisterExtendedReportingOnlyDelayedAnalysisCallback(

Nathan Parker 2016/02/22 19:58:01 I'm wondering if it'd be simpler to add a method t

proberge 2016/02/22 20:09:42 I believe we expose AddDownloadManager instead of

+ const DelayedAnalysisCallback& callback);

#endif

// Adds |download_manager| to the set monitored by safe browsing.