Add a ModuleLoadAnalyzer which checks modules against a whitelist

chrome/browser/safe_browsing/safe_browsing_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 
@@ skipping 130 matching lines @@
   // incident reporting service for validation failures. Returns NULL if the
   // service is not applicable for the given profile.
   scoped_ptr<TrackedPreferenceValidationDelegate>
       CreatePreferenceValidationDelegate(Profile* profile) const;
 
 #if defined(FULL_SAFE_BROWSING)
   // Registers |callback| to be run after some delay following process launch.
   // |callback| will be dropped if the service is not applicable for the
   // process.
   void RegisterDelayedAnalysisCallback(const DelayedAnalysisCallback& callback);
+  void RegisterExtendedReportingOnlyDelayedAnalysisCallback(

[Nathan Parker, 2016/02/22 19:58:01]

I'm wondering if it'd be simpler to add a method to expose the
incident_service_, and remove these plus the AddDownloadManager.  what do you
think?

[proberge, 2016/02/22 20:09:42]

I believe we expose AddDownloadManager instead of GetIncidentService to avoid
exposing a large interface to other parts of Chrome. To me it seems reasonable
to have all calls from outside of browser/safebrowsing have to go through this
service.
(AddDownloadManager is called from
chrome/browser/download/chrome_download_manager_delegate.cc)

For the duplicated mehtod, we're thinking about enabling IncidentReporting only
for users that have extended reporting enabled, in which case we could clean
this up a little.

+      const DelayedAnalysisCallback& callback);
 #endif
 
   // Adds |download_manager| to the set monitored by safe browsing.
   void AddDownloadManager(content::DownloadManager* download_manager);
 
   // Observes resource requests made by the renderer and reports suspicious
   // activity.
   void OnResourceRequest(const net::URLRequest* request);
 
   // Type for subscriptions to SafeBrowsing service state.
@@ skipping 148 matching lines @@
   SafeBrowsingServiceFactory() { }
   virtual ~SafeBrowsingServiceFactory() { }
   virtual SafeBrowsingService* CreateSafeBrowsingService() = 0;
  private:
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingServiceFactory);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_