Detect cache line size on Linux for PPC hosts.

Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=

Committed: https://crrev.com/c3ff68b6b76ff1ffa1f6cd7c82181366020a0fe2
Cr-Commit-Position: refs/heads/master@{#33642}

[MTBrandyberry, 2016-01-29 20:46:43]

The CQ bit was checked by mbrandy@us.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 20:46:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643363002/1

[commit-bot: I haz the power, 2016-01-29 21:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 21:08:55]

Dry run: This issue passed the CQ dry run.

[MTBrandyberry, 2016-01-29 21:09:37]

PTAL

[MTBrandyberry, 2016-01-29 21:11:26]

Description was changed from

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

to

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

[rmcilroy, 2016-02-01 14:30:18]

lgtm

[jochen (gone - plz use gerrit), 2016-02-01 14:30:41]

lgtm

[MTBrandyberry, 2016-02-01 14:38:23]

The CQ bit was checked by mbrandy@us.ibm.com

[commit-bot: I haz the power, 2016-02-01 14:38:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1643363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1643363002/1

[commit-bot: I haz the power, 2016-02-01 15:03:04]

Description was changed from

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

to

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

[commit-bot: I haz the power, 2016-02-01 15:03:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-01 15:03:31]

Description was changed from

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
==========

to

==========
Detect cache line size on Linux for PPC hosts.

In the interest of generalization, this change:
- Consolidates cache line size detection for all interested
  architectures under base::CPU (currently leveraged by only
  PPC and ARM64).
- Differentiates between instruction vs data cache line sizes.

R=rmcilroy@chromium.org, jochen@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=

Committed: https://crrev.com/c3ff68b6b76ff1ffa1f6cd7c82181366020a0fe2
Cr-Commit-Position: refs/heads/master@{#33642}
==========

[commit-bot: I haz the power, 2016-02-01 15:03:31]

Patchset 1 (id:??) landed as
https://crrev.com/c3ff68b6b76ff1ffa1f6cd7c82181366020a0fe2
Cr-Commit-Position: refs/heads/master@{#33642}

[Riku Voipio, 2016-02-10 12:48:29]

On 2016/02/01 15:03:31, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c3ff68b6b76ff1ffa1f6cd7c82181366020a0fe2
> Cr-Commit-Position: refs/heads/master@{#33642}

This appears to break v8 on arm64:

[14/16618] ACTION v8_external_snapshot: run_mksnapshot
(external)_d7a316e05e7b0a438c42a81cdde1cb2e
FAILED: cd ../../v8/tools/gyp; ../../../out/Release/mksnapshot
--log-snapshot-positions --logfile
../../../out/Release/obj/v8/tools/gyp/v8_external_snapshot.gen/snapshot.log
--random-seed 314159265 --startup_blob ../../../out/Release/snapshot_blob.bin ""
Segmentation fault

backtrace from mksnapshot:

Program received signal SIGSEGV, Segmentation fault.
0x000000000072e154 in v8::internal::CpuFeatures::FlushICache(void*, unsigned
long) ()
(gdb) bt
#0  0x000000000072e154 in v8::internal::CpuFeatures::FlushICache(void*, unsigned
long) ()
#1  0x000000000070caac in
v8::internal::CodeAgingHelper::CodeAgingHelper(v8::internal::Isolate*) ()
#2  0x00000000005f0b1c in
v8::internal::Isolate::Init(v8::internal::Deserializer*) ()
#3  0x000000000040752c in v8::V8::CreateSnapshotDataBlob(char const*) ()
#4  0x000000000040686c in main ()

reverting this commit builds a mksnapshot that doesn't segfault here.

[rmcilroy, 2016-02-10 13:25:44]

On 2016/02/10 12:48:29, Riku Voipio wrote:
> On 2016/02/01 15:03:31, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/c3ff68b6b76ff1ffa1f6cd7c82181366020a0fe2
> > Cr-Commit-Position: refs/heads/master@{#33642}
> 
> This appears to break v8 on arm64:
> 
> [14/16618] ACTION v8_external_snapshot: run_mksnapshot
> (external)_d7a316e05e7b0a438c42a81cdde1cb2e
> FAILED: cd ../../v8/tools/gyp; ../../../out/Release/mksnapshot
> --log-snapshot-positions --logfile
> ../../../out/Release/obj/v8/tools/gyp/v8_external_snapshot.gen/snapshot.log
> --random-seed 314159265 --startup_blob ../../../out/Release/snapshot_blob.bin
""
> Segmentation fault
> 
> backtrace from mksnapshot:
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x000000000072e154 in v8::internal::CpuFeatures::FlushICache(void*, unsigned
> long) ()
> (gdb) bt
> #0  0x000000000072e154 in v8::internal::CpuFeatures::FlushICache(void*,
unsigned
> long) ()
> #1  0x000000000070caac in
> v8::internal::CodeAgingHelper::CodeAgingHelper(v8::internal::Isolate*) ()
> #2  0x00000000005f0b1c in
> v8::internal::Isolate::Init(v8::internal::Deserializer*) ()
> #3  0x000000000040752c in v8::V8::CreateSnapshotDataBlob(char const*) ()
> #4  0x000000000040686c in main ()
> 
> reverting this commit builds a mksnapshot that doesn't segfault here.

Our build-bots (https://build.chromium.org/p/client.v8/console) show Arm64
building and running tests fine. Do you have any patches or local config changes
in your build? Or are you compiling on Arm64 for Arm64 (rather than
cross-compiling as we usually do)?

[Jakob Kummerow, 2016-03-11 12:27:04]

On 2016/02/10 12:48:29, Riku Voipio wrote:
> This appears to break v8 on arm64:

If I had to guess: https://codereview.chromium.org/1783343002 ;-)