Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost

content/browser/worker_host/worker_service_impl.cc

Index: content/browser/worker_host/worker_service_impl.cc
diff --git a/content/browser/worker_host/worker_service_impl.cc b/content/browser/worker_host/worker_service_impl.cc
index bd6a19d44e4ebfa3380e47c103e25e64b119789b..ca5652e7da08bc4e07c020339b9520e82850c944 100644
--- a/content/browser/worker_host/worker_service_impl.cc
+++ b/content/browser/worker_host/worker_service_impl.cc
@@ -110,25 +110,18 @@ void WorkerPrioritySetter::GatherVisibleIDsAndUpdateWorkerPriorities() {
       new std::set<std::pair<int, int> >();
 
   // Gather up all the visible renderer process/view pairs
-  for (RenderProcessHost::iterator it =
-       RenderProcessHost::AllHostsIterator();
-       !it.IsAtEnd(); it.Advance()) {
-    RenderProcessHost* render_process_host = it.GetCurrentValue();
-    if (render_process_host->VisibleWidgetCount()) {
-      for (RenderProcessHost::RenderWidgetHostsIterator rit =
-           render_process_host->GetRenderWidgetHostsIterator(); !rit.IsAtEnd();
-           rit.Advance()) {
-        RenderWidgetHost* render_widget =
-            render_process_host->GetRenderWidgetHostByID(rit.GetCurrentKey());
-        if (render_widget) {
-          RenderWidgetHostView* render_view = render_widget->GetView();
-          if (render_view && render_view->IsShowing()) {
-            visible_renderer_ids->insert(
-                std::pair<int, int>(render_process_host->GetID(),
-                                    render_widget->GetRoutingID()));
-          }
-        }
-      }
+  RenderWidgetHost::List widgets = RenderWidgetHost::GetRenderWidgetHosts();
+  for (RenderWidgetHost::List::const_iterator it = widgets.begin();

[jam, 2013/06/12 19:59:59]

since this is a vector,

for (size_t i = 0; i < widgets.size(); ++i)

is a more concise and readable

[nasko, 2013/06/12 21:18:59]

Done.

+      it != widgets.end(); ++it) {
+    const RenderWidgetHost* widget = *it;
+    if (widget->GetProcess()->VisibleWidgetCount() == 0)
+      continue;
+
+    RenderWidgetHostView* render_view = widget->GetView();
+    if (render_view && render_view->IsShowing()) {
+      visible_renderer_ids->insert(
+          std::pair<int, int>(widget->GetProcess()->GetID(),
+                              widget->GetRoutingID()));
     }
   }