Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost

content/browser/worker_host/worker_service_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/worker_host/worker_service_impl.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 92 matching lines @@
           &WorkerPrioritySetter::GatherVisibleIDsAndUpdateWorkerPriorities,
           this));
 }
 
 void WorkerPrioritySetter::GatherVisibleIDsAndUpdateWorkerPriorities() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   std::set<std::pair<int, int> >* visible_renderer_ids =
       new std::set<std::pair<int, int> >();
 
   // Gather up all the visible renderer process/view pairs
-  for (RenderProcessHost::iterator it =
-       RenderProcessHost::AllHostsIterator();
-       !it.IsAtEnd(); it.Advance()) {
-    RenderProcessHost* render_process_host = it.GetCurrentValue();
-    if (render_process_host->VisibleWidgetCount()) {
-      for (RenderProcessHost::RenderWidgetHostsIterator rit =
-           render_process_host->GetRenderWidgetHostsIterator(); !rit.IsAtEnd();
-           rit.Advance()) {
-        RenderWidgetHost* render_widget =
-            render_process_host->GetRenderWidgetHostByID(rit.GetCurrentKey());
-        if (render_widget) {
-          RenderWidgetHostView* render_view = render_widget->GetView();
-          if (render_view && render_view->IsShowing()) {
-            visible_renderer_ids->insert(
-                std::pair<int, int>(render_process_host->GetID(),
-                                    render_widget->GetRoutingID()));
-          }
-        }
-      }
+  RenderWidgetHost::List widgets = RenderWidgetHost::GetRenderWidgetHosts();
+  for (RenderWidgetHost::List::const_iterator it = widgets.begin();

[jam, 2013/06/12 19:59:59]

since this is a vector,

for (size_t i = 0; i < widgets.size(); ++i)

is a more concise and readable

[nasko, 2013/06/12 21:18:59]

Done.

+      it != widgets.end(); ++it) {
+    const RenderWidgetHost* widget = *it;
+    if (widget->GetProcess()->VisibleWidgetCount() == 0)
+      continue;
+
+    RenderWidgetHostView* render_view = widget->GetView();
+    if (render_view && render_view->IsShowing()) {
+      visible_renderer_ids->insert(
+          std::pair<int, int>(widget->GetProcess()->GetID(),
+                              widget->GetRoutingID()));
     }
   }
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&WorkerPrioritySetter::UpdateWorkerPrioritiesFromVisibleSet,
                  this, base::Owned(visible_renderer_ids)));
 }
 
 void WorkerPrioritySetter::UpdateWorkerPrioritiesFromVisibleSet(
@@ skipping 583 matching lines @@
     return instance;
 
   // No existing pending worker - create a new one.
   WorkerProcessHost::WorkerInstance pending(
       url, true, name, resource_context, partition);
   pending_shared_workers_.push_back(pending);
   return &pending_shared_workers_.back();
 }
 
 }  // namespace content