Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Windows compile error. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 5f528b1c491377884b78673a405e88c1fea24d69..0b68794cf551fa62b31633ad5c1043c2cb857ceb 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -76,6 +76,8 @@ class CONTENT_EXPORT RenderProcessHostImpl
virtual void EnableSendQueue() OVERRIDE;
virtual bool Init() OVERRIDE;
virtual int GetNextRoutingID() OVERRIDE;
+ virtual void AddRoute(int32 routing_id, IPC::Listener* listener) OVERRIDE;
+ virtual void RemoveRoute(int32 routing_id) OVERRIDE;
virtual void SimulateSwapOutACK(const ViewMsg_SwapOut_Params& params)
OVERRIDE;
virtual bool WaitForBackingStoreMsg(int render_widget_id,
@@ -97,20 +99,14 @@ class CONTENT_EXPORT RenderProcessHostImpl
StoragePartition* partition) const OVERRIDE;
virtual int GetID() const OVERRIDE;
virtual bool HasConnection() const OVERRIDE;
- virtual RenderWidgetHost* GetRenderWidgetHostByID(int routing_id)
- OVERRIDE;
virtual void SetIgnoreInputEvents(bool ignore_input_events) OVERRIDE;
virtual bool IgnoreInputEvents() const OVERRIDE;
- virtual void Attach(RenderWidgetHost* host, int routing_id)
- OVERRIDE;
- virtual void Release(int routing_id) OVERRIDE;
virtual void Cleanup() OVERRIDE;
virtual void AddPendingView() OVERRIDE;
virtual void RemovePendingView() OVERRIDE;
virtual void SetSuddenTerminationAllowed(bool enabled) OVERRIDE;
virtual bool SuddenTerminationAllowed() const OVERRIDE;
virtual IPC::ChannelProxy* GetChannel() OVERRIDE;
- virtual RenderWidgetHostsIterator GetRenderWidgetHostsIterator() OVERRIDE;
virtual bool FastShutdownForPageCount(size_t count) OVERRIDE;
virtual bool FastShutdownStarted() const OVERRIDE;
virtual base::TimeDelta GetChildProcessIdleTime() const OVERRIDE;
@@ -189,10 +185,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
// browser_process.h)
scoped_ptr<IPC::ChannelProxy> channel_;
- // The registered render widget hosts. When this list is empty or all NULL,
- // we should delete ourselves
- IDMap<RenderWidgetHost> render_widget_hosts_;
-
// True if fast shutdown has been performed on this RPH.
bool fast_shutdown_started_;
@@ -239,6 +231,10 @@ class CONTENT_EXPORT RenderProcessHostImpl
virtual void OnGpuSwitching() OVERRIDE;
+ // The registered IPC listener objects. When this list is empty, we should
+ // delete ourselves.
+ IDMap<IPC::Listener> listeners_;
+
// The count of currently visible widgets. Since the host can be a container
// for multiple widgets, it uses this count to determine when it should be
// backgrounded.

Powered by Google App Engine
This is Rietveld 408576698