content/browser/renderer_host/media/web_contents_video_capture_device.cc - Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/web_contents_video_capture_device.cc

Issue 16431010: Refactor RenderProcessHost to use IPC::Listener instead of RenderWidgetHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing Windows compile error. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/render_view_devtools_agent_host.cc ('K') | « content/browser/gpu/gpu_process_host_ui_shim.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/web_contents_video_capture_device.cc

diff --git a/content/browser/renderer_host/media/web_contents_video_capture_device.cc b/content/browser/renderer_host/media/web_contents_video_capture_device.cc

index 52be61a089101fd2766239501ea1372e061fceb2..3afde9b5511aa09dd5003a919324ba6487d578f1 100644

--- a/content/browser/renderer_host/media/web_contents_video_capture_device.cc

+++ b/content/browser/renderer_host/media/web_contents_video_capture_device.cc

@@ -873,8 +873,11 @@ RenderWidgetHost* CaptureMachine::GetTarget() {

RenderWidgetHost* rwh = NULL;

if (fullscreen_widget_id_ != MSG_ROUTING_NONE) {

RenderProcessHost* process = web_contents()->GetRenderProcessHost();

- rwh = process ? process->GetRenderWidgetHostByID(fullscreen_widget_id_)

- : NULL;

+ if (process) {

+ rwh = RenderWidgetHost::FromID(process->GetID(), fullscreen_widget_id_);

+ } else {

+ rwh = NULL;

jam 2013/06/12 19:59:59 nit: skip the else, it's not needed since rwh is i

nasko 2013/06/12 21:18:59 Done.

+ }

} else {

rwh = web_contents()->GetRenderViewHost();

}