Precompilation: when removing top-level fields and functions, also remove them from the library dic…

Precompilation: when removing top-level fields and functions, also remove them from the library dictionary.

precompiled dart2js x64 21545468 -> 21521876 (-0.11%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/af10c8ceb74f86a445f45a160dbf2cec229a53f1

[rmacnak, 2016-02-02 19:33:32]

Description was changed from

==========
Precompilation: when removing top-level fields and functions, also remove them
from the library dictionary.

precompiled dart2js x64 21544289 -> 21509263 (-0.16%)
==========

to

==========
Precompilation: when removing top-level fields and functions, also remove them
from the library dictionary.

precompiled dart2js x64 21545468 -> 21521876 (-0.11%)
==========

[rmacnak, 2016-02-02 20:27:02]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-02-02 21:30:20]

lgtm

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9723: HashTables::New<ResolvedNamesMap>(0));
Can you use InvalidateResolvedNamesCache? Or use a canonical empty map?

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:920: bool top_level = cls.IsTopLevel();
Move this right before its use?

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:940: (function.kind() !=
RawFunction::kImplicitStaticFinalGetter)) {
Why not for implicit static final getters?

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:997: bool top_level = cls.IsTopLevel();
Move this right before its use?

[rmacnak, 2016-02-03 01:43:40]

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:9723: HashTables::New<ResolvedNamesMap>(0));
On 2016/02/02 21:30:19, Florian Schneider wrote:
> Can you use InvalidateResolvedNamesCache? Or use a canonical empty map?

Switched to InvalidateResolvedNamesCache

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:920: bool top_level = cls.IsTopLevel();
On 2016/02/02 21:30:20, Florian Schneider wrote:
> Move this right before its use?

Done.

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:940: (function.kind() !=
RawFunction::kImplicitStaticFinalGetter)) {
On 2016/02/02 21:30:20, Florian Schneider wrote:
> Why not for implicit static final getters?

They aren't in the library dictionary in the first place, so the assert that we
removed something fails. Added comment to this effect.

https://codereview.chromium.org/1643023003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:997: bool top_level = cls.IsTopLevel();
On 2016/02/02 21:30:19, Florian Schneider wrote:
> Move this right before its use?

Done.

[rmacnak, 2016-02-03 21:11:52]

Description was changed from

==========
Precompilation: when removing top-level fields and functions, also remove them
from the library dictionary.

precompiled dart2js x64 21545468 -> 21521876 (-0.11%)
==========

to

==========
Precompilation: when removing top-level fields and functions, also remove them
from the library dictionary.

precompiled dart2js x64 21545468 -> 21521876 (-0.11%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af10c8ceb74f86a445f45a160dbf2cec229a53f1
==========

[rmacnak, 2016-02-03 21:11:53]

Committed patchset #2 (id:20001) manually as
af10c8ceb74f86a445f45a160dbf2cec229a53f1 (presubmit successful).