runtime/vm/compiler.cc - Issue 1643023003: Precompilation: when removing top-level fields and functions, also remove them from the library dic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 1643023003: Precompilation: when removing top-level fields and functions, also remove them from the library dic… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index 3ce18f89e3ec5d94364f1c8c7e91788cf8633228..58b4a35a0185c7762e3b69a677e6d2ca455cba41 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -1942,7 +1942,11 @@ void BackgroundCompiler::EnsureInit(Thread* thread) {

DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {

- UNREACHABLE();

+ const Function& function = Function::CheckedHandle(arguments.ArgAt(0));

+ FATAL3("Precompilation missed function %s (%" Pd ", %s)\n",

+ function.ToLibNamePrefixedQualifiedCString(),

+ function.token_pos(),

+ Function::KindToCString(function.kind()));

}

« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | runtime/vm/object.cc » ('J')