Accurately type foreign functions, and variables.

Accurately type foreign functions, and variables.

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/b1d43d0b31e8aea7b31261764fef5bee4ad13903
Cr-Commit-Position: refs/heads/master@{#33596}

[aseemgarg, 2016-01-28 23:09:27]

lgtm

[aseemgarg, 2016-01-28 23:09:59]

https://codereview.chromium.org/1642993002/diff/20001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1642993002/diff/20001/src/typing-asm.h#newcod...
src/typing-asm.h:165: void VisitVariableProxy(VariableProxy* expr, bool
assignment);
make this private?

[bradn, 2016-01-29 01:03:38]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-01-29 01:03:38]

https://codereview.chromium.org/1642993002/diff/20001/src/typing-asm.h
File src/typing-asm.h (right):

https://codereview.chromium.org/1642993002/diff/20001/src/typing-asm.h#newcod...
src/typing-asm.h:165: void VisitVariableProxy(VariableProxy* expr, bool
assignment);
On 2016/01/28 23:09:59, aseemgarg wrote:
> make this private?

It is?

[bradn, 2016-01-29 01:03:54]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-01-29 01:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642993002/20001

[commit-bot: I haz the power, 2016-01-29 01:05:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 01:05:57]

Description was changed from

==========
Accurately type foreign functions, and variables.

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Accurately type foreign functions, and variables.

Associate a type with foreign functions at their callsite.
Associate a type with foreign variables.
More pervasively forbid computation in the module body.
Confirm foreign call arguments are exports.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/b1d43d0b31e8aea7b31261764fef5bee4ad13903
Cr-Commit-Position: refs/heads/master@{#33596}
==========

[commit-bot: I haz the power, 2016-01-29 01:05:58]

Patchset 2 (id:??) landed as
https://crrev.com/b1d43d0b31e8aea7b31261764fef5bee4ad13903
Cr-Commit-Position: refs/heads/master@{#33596}

[Michael Achenbach, 2016-01-29 07:37:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1648063003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks arm x-compile:
https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builde....